-
Notifications
You must be signed in to change notification settings - Fork 23
process: add initial tool management #932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-check Status: ✅ Passed Click to expand output
|
The created documentation from the pull request is available at: docu-html |
3242aa0
to
af8341c
Compare
af8341c
to
c0e3042
Compare
c0e3042
to
f8a7453
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see inline comments
docs/process/process_areas/tool_management/tool_management_getstrt.rst
Outdated
Show resolved
Hide resolved
docs/process/process_areas/tool_management/tool_management_workflow.rst
Outdated
Show resolved
Hide resolved
docs/process/process_areas/tool_management/tool_management_workflow.rst
Outdated
Show resolved
Hide resolved
docs/process/process_areas/tool_management/tool_management_workproducts.rst
Outdated
Show resolved
Hide resolved
docs/process/process_areas/tool_management/guidance/tool_management_checklist.rst
Show resolved
Hide resolved
docs/process/process_areas/tool_management/guidance/tool_management_template.rst
Show resolved
Hide resolved
docs/process/process_areas/tool_management/guidance/tool_management_checklist.rst
Outdated
Show resolved
Hide resolved
f8a7453
to
37c6d46
Compare
The purpose of the Tool Management Plan is to guide the identification, evaluation and qualification of | ||
project tools. | ||
|
||
S-CORE objectives is to use OSS tools for the generation of all required work products. Thus all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also use GitHub as a "tool". This is not open source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rephrased
|
||
**To Step 2** | ||
|
||
Based on the found malfunctions or threats judge, if these can be all detected or prevented? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a question and hard to understand. Better use:
Based on the found malfunctions or threats judge, if these can be all detected or prevented? | |
Based on the malfunctions or threats found, assess whether these can be detected or prevented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
taken over
Qualification | ||
^^^^^^^^^^^^^ | ||
|
||
As method validation of software tool is applied. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The method used is the validation of the software tool.
Or
The method used is software tool validation.
Or
As method "validation of software tool" is applied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified to match last version
Update the Tool Verification Report accordingly to document the outcomes. | ||
|
||
For the generation of requirements, verification and analyses the processes defined in the | ||
:need:`wp__platform_mgmt` shall be used (Requirements Engineering, Verification, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it improve the quality to link to the respective parts for requirements, etc. rather than just say "read the platform management plan"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add concrete links, as available for now
:complies: std_req__iso26262__support_1141, std_req__iso26262__support_1142, std_req__iso26262__support_1143, std_req__iso26262__support_11441, std_req__iso26262__support_11442, std_req__iso26262__support_11451, std_req__iso26262__support_11452, std_req__iso26262__support_11453, std_req__iso26262__support_11454, std_req__iso26262__support_11461, std_req__iso26262__support_11462 | ||
|
||
| **1. Purpose** | ||
| The purpose of this checklist is to collect the topics to be checked during a tool verification.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two "." at the end of the sentence
| The purpose of this checklist is to collect the topics to be checked during a tool verification.. | |
| The purpose of this checklist is to collect the topics to be checked during a tool verification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed one
|
||
| **1. Purpose** | ||
| The purpose of this checklist is to collect the topics to be checked during a tool verification.. | ||
| It will not be filled out but considered during the review and monitoring to complete of the Tool Verification Report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| It will not be filled out but considered during the review and monitoring to complete of the Tool Verification Report. | |
| It will not be filled out, but considered during the review and monitoring to complete of the Tool Verification Report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adapted
|
||
**Optional Section for Tool Qualification** | ||
------------------------------------------- | ||
based on method: validation of the software tool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
based on method: validation of the software tool | |
Based on method: validation of the software tool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed
Key concept | ||
*********** | ||
S-CORE objective is to use OSS Tools only. The selection criteria for OSS Tool therefore must | ||
include the determination of the Tool Confidence Level `(TCL) <https://www.validas.de/publications/automotive2012.pdf>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean that if a tool is not OSS, I do not need a TCL?
It says currently: S-CORE only uses OSS tools [...] therefore must include [...] TCL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, rephrased
|
||
Activities for Tool Management | ||
****************************** | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tlm stands for tool management correct? Why not referring to as tool_mgmt_creation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed as this was some wrong documentation
ed3fa5e
to
4de368a
Compare
The purpose of the Tool Management Plan is to guide the identification, evaluation and qualification of | ||
project tools. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using "qualification" without a clear reference to safety is confusing?! As usually there is no qualification. Maybe just change it to "safety qualification"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please again, forgot looking only to safety, our process framework does conform to multiple standards and for you as user, only our process are relevant, the framework is mapped to the relevant standard and it defines, what we do for qualification, in our case. I add for current state just safe and secure use of tools, maybe replace in future by trustable use in the tool, where trustable may include more than safe and secure
Qualification | ||
^^^^^^^^^^^^^ | ||
|
||
As method "validation of software tool" is applied. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not apply the other methods? I would personally much rather have a tool development process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What development process? I just said, that we use S-CORE parts for tools too, and independent of that, having requirements or goals or how ever you call it, and you test that is minimum in my view
* Make familiar with the development and supporting process descriptions in :ref:`process_description` | ||
* Make familiar with the relevant sections of the :ref:`Platform Management Plan <pmp>`, here especially with :need:`Tool Management Plan <doc__platform_tool_management_plan>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Make familiar with the development and supporting process descriptions in :ref:`process_description` | |
* Make familiar with the relevant sections of the :ref:`Platform Management Plan <pmp>`, here especially with :need:`Tool Management Plan <doc__platform_tool_management_plan>` | |
* Make yourself familiar with the development and supporting process descriptions in :ref:`process_description` | |
* Make yourself familiar with the relevant sections of the :ref:`Platform Management Plan <pmp>`, here especially with :need:`Tool Management Plan <doc__platform_tool_management_plan>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unclear, just understood you changed the order, that is done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added "yourself" --> "Make yourself familiar"
docs/process/process_areas/tool_management/tool_management_workflow.rst
Outdated
Show resolved
Hide resolved
docs/process/process_areas/tool_management/tool_management_workflow.rst
Outdated
Show resolved
Hide resolved
|
||
Finally the Tool Verification Report is verified and approved, and thus in Released state. | ||
|
||
For creating the Tool Verification Report a template must be used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"The defined template"?
Note however, that technically we'll most likely use markdown or even yaml and not rst files for that. However we can use the template chapters etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you see in the needs the linked templates, so I added the linked template, which is visible in the Sphinx HTML documentation
docs/process/process_areas/tool_management/tool_management_workproducts.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my remarks are all covered
Resolves: #858
4de368a
to
bd7e53e
Compare
@masc2023 I would highly recommend pushing new commits instead of squashing locally. I now have no chance to see what has changed since my review. |
Resolves: #858